HURD support, build fails, maybe an easy fix [patch]

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

HURD support, build fails, maybe an easy fix [patch]

Daniel Pocock
Package: rrdtool
Version: 1.4.7-2

I notice that the HURD build is failing with an error about PATH_MAX

This is a common issue.  PATH_MAX doesn't exist in HURD and it is very
trivial to work around

Full build log:

https://buildd.debian.org/status/fetch.php?pkg=rrdtool&arch=hurd-i386&ver=1.4.7-2&stamp=1343897555

Error:

rrd_client.c: In function 'rrdc_update':
rrd_client.c:586:18: error: 'PATH_MAX' undeclared (first use in this function)
rrd_client.c:586:18: note: each undeclared identifier is reported only once for each function it appears in
rrd_client.c:586:8: warning: unused variable 'file_path' [-Wunused-variable]
rrd_client.c: In function 'rrdc_flush':
rrd_client.c:647:18: error: 'PATH_MAX' undeclared (first use in this function)
rrd_client.c:647:8: warning: unused variable 'file_path' [-Wunused-variable]
make[3]: *** [rrd_client.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
make: *** [build-arch-stamp] Error 2




Discussion:

http://www.gnu.org/software/hurd/community/gsoc/project_ideas/maxpath.html


Potential solution:

http://www.gnu.org/software/hurd/hurd/porting/guidelines.html#PATH_MAX_tt_MAX_PATH_tt_MAXPATHL

Attached is an example of a patch from another project, it appears easy enough to cut and paste into rrd_client.c




_______________________________________________
rrd-developers mailing list
[hidden email]
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

cpulimit-path-max-fix.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: HURD support, build fails, maybe an easy fix [patch]

Svante Signell
On Fri, 2013-09-06 at 14:19 +0200, Daniel Pocock wrote:
> Package: rrdtool
> Version: 1.4.7-2
>
> I notice that the HURD build is failing with an error about PATH_MAX
>
> This is a common issue.  PATH_MAX doesn't exist in HURD and it is very
> trivial to work around

Hello, if you take a look at the rrdtool mailing list archives, I'm
communicating with upstream about patches solving the PATH_MAX problems.
Unfortunately I'm not yet finished with the updated patches, stay tuned.

Regarding the fix for cpulimit it did not work for me. Maybe I got it
wrong, why not try it yourself.

Svante

_______________________________________________
rrd-developers mailing list
[hidden email]
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers